feat(match2): support for hero bans on deadlock #4879
Merged
+40
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rathoz
reviewed
Oct 15, 2024
Rathoz
reviewed
Oct 15, 2024
Rathoz
reviewed
Oct 15, 2024
Rathoz
reviewed
Oct 15, 2024
Rathoz
reviewed
Oct 15, 2024
hjpalpha
reviewed
Oct 15, 2024
components/match2/wikis/deadlock/get_match_group_copy_paste_wiki.lua
Outdated
Show resolved
Hide resolved
hjpalpha
reviewed
Oct 16, 2024
Co-authored-by: Rikard Blixt <[email protected]>
Co-authored-by: Rikard Blixt <[email protected]>
Co-authored-by: Rikard Blixt <[email protected]>
Rathoz
reviewed
Oct 17, 2024
Rathoz
approved these changes
Oct 17, 2024
hjpalpha
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding support for Hero Bans in Deadlock
The number of bans/ban format is currently community driven, so the current display supporting up to 6 bans should be future proof
How did you test this change?
Dev modules:
https://liquipedia.net/deadlock/Module:MatchGroup/Input/Custom/dev/kano
https://liquipedia.net/deadlock/Module:MatchSummary/dev/kano
Test page:
https://liquipedia.net/deadlock/User:Kanoodles/test